use ttl before caching - Githubissues

amphp / dns

Async DNS resolution for PHP based on Amp.

https://amphp.org/dns

MIT License

157 stars 32 forks source link

use ttl before caching #57

Closed Peleg closed 7 years ago

Peleg commented 7 years ago

seems like we currently use the record type const for ttl instead of the returned value for ttl as being set here: https://github.com/amphp/dns/compare/master...Peleg:use-ttl?expand=1#diff-95976616e9bed72530f27e1aa008eb0cR638

mention-bot commented 7 years ago

@Peleg, thanks for your PR! By analyzing the history of the files in this pull request, we identified @kelunik, @bwoebi and @trowski to be potential reviewers.

DaveRandom commented 7 years ago

Thanks for this, I had never noticed this but I imagine this could result in some super confusing bugs!