search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Tests fail with OPCache enabled #58

Closed kelunik closed 7 years ago

kelunik commented 7 years ago

Quite a few tests fail with OPCache enabled, because Socket::ask yields an empty array instead of an instance of Message.

kelunik commented 7 years ago

"Solved" by https://github.com/amphp/dns/commit/e0fc018ad7473cd24b188323393476c5a19a6d35.

PeeHaa commented 7 years ago

Is this (return yield) an issue in general with opcache or just this specific piece of code?

kelunik commented 7 years ago

It's a general issue with opcache + return in try + finally.

bwoebi commented 7 years ago

But just within Generators.

PeeHaa commented 7 years ago

kk tnx both ❤️