search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Fix a precedence issue on the ConfigLoader parameter #61

Closed far-blue closed 7 years ago

far-blue commented 7 years ago

Fix a precedence issue where supplying your own ConfigLoader to the BasicResolver resulted in a WindowsConfigLoader being instantiated instead.

kelunik commented 7 years ago

Thanks! What's the reason for using a custom config loader if I may ask?

far-blue commented 7 years ago

I'm using the lack of DNS records as part of a number of checks for domain availability so I needed a Resolver config that had static server config, no hosts file, a very fast timeout and no retry attempts. Very much an unusual case :) I've also disabled the cache - although as the NullCache class in the cache package is only on master at the moment I had to copy it rather than use it.

kelunik commented 7 years ago

I can just release a new version there, could you open an issue?

I've just released amphp/cache v1.1.0.

far-blue commented 7 years ago

thanks for the releases :)