search

amphp / dns

Async DNS resolution for PHP based on Amp.
https://amphp.org/dns
MIT License
157 stars 32 forks source link

Bump the minimum version of amphp/uri #79

Closed PeeHaa closed 5 years ago

PeeHaa commented 5 years ago

Currently the minimum supported version of amphp/uri in composer uses a broken version: ^1.0.

TypeError: Return value of Amp\Uri\Uri::getQueryParameter() must be of the type string, null returned

Can this be bumped to at least version ^0.1.1, but probably better to just use latest.

Bonus internet points if the above change is topped off with a fresh release containing the change <3

kelunik commented 5 years ago

PR is welcome 😉

trowski commented 5 years ago

Seems we really only use the uri package for the normalizeDnsName function. Should we drop this function into socket or some other package and deprecate the uri package? We also may be able to use league/uri.

Edit: Err… or rather this package. I forget socket is actually dependent on this package.

PeeHaa commented 5 years ago

If that's the case that would be much nicer indeed
Looking at the function itself it could even be just included directly in dns Or is the normalization done in other packages as well?

trowski commented 5 years ago

Closing since we dumped the amphp/uri dependency.