Add path not exists exception which specifies the path

amphp / file

An abstraction layer and non-blocking file access solution that keeps your application responsive.

MIT License

97 stars 25 forks source link

Add path not exists exception which specifies the path #41

Open dantleech opened 4 years ago

dantleech commented 4 years ago

Specify the path which doesn't exist when the path doesn't exist.

~~I can't test this locally as I don't have the necessary extensions (eio, uv) to install the dev dependencies.~~ I manually deleted the extension deps from composer.

Looks like you also need to update Travis - the legacy integrations have broken.. (you can migrate here )

dantleech commented 4 years ago

There doesn't seem to be any tests for path not exists - and I think it should be consistent across drivers, so could do:

Add tests for "not exists" to the driver test case and update all the other implementations
OR
Remove the custom exception and just add a factory method for the exception in ParallelDriver

enumag commented 4 years ago

Shouldn't you update all drivers?