Return written length in blocking and parallel drivers

amphp / file

An abstraction layer and non-blocking file access solution that keeps your application responsive.

MIT License

98 stars 25 forks source link

Return written length in blocking and parallel drivers #64

Closed danog closed 2 years ago

kelunik commented 2 years ago

We returned the length in previous versions, but have moved away from that.

danog commented 2 years ago

Should I edit the uv end eio drivers to not return the length anymore then? The API should also be updated: https://github.com/amphp/file/blob/master/src/File.php#L31

trowski commented 2 years ago

@kelunik Seems we declared it in the interface, so maybe we should for this version? We can be sure to remove it for v3.

kelunik commented 2 years ago

@trowski You're right, returning a value there is the more BC version, even if I tend to see the blocking / parallel drivers as reference implementation.