Add PSR-7 request adapter (#266)

amphp / http-client

An advanced async HTTP client library for PHP, enabling efficient, non-blocking, and concurrent requests and responses.

https://amphp.org/http-client

MIT License

704 stars 66 forks source link

Closed remorhaz closed 4 years ago

remorhaz commented 4 years ago

This PR shows partial job, just to sync expectations. It only implements converting requests between Amp and PSR-7 and vice versa.

remorhaz commented 4 years ago

I've made some changes:

Added response adapters;
Adapter returns promises instead of "direct" objects;
Message bodies are buffered entirely before resolving the message promise (escaping wait() issues).
Minor codestyle fixes, tests added, etc.

trowski commented 4 years ago

I agree with @kelunik, this really should be a separate package.

See the PSR adaptor I've been working on for http-server: https://github.com/trowski/psr-http-bridge

remorhaz commented 4 years ago

So, should I move my code to separate repository?

kelunik commented 4 years ago

@remorhaz Do you want to maintain it yourself or should I create a new repository in the @amphp namespace? I'd be fine with both.

remorhaz commented 4 years ago

I guess it's better to keep it in amphp space.

remorhaz commented 4 years ago

@kelunik, so what about a new repository?

kelunik commented 4 years ago

@remorhaz I've just created https://github.com/amphp/http-client-psr7, so you can PR against that. :-)

enumag commented 4 years ago

ping @remorhaz

remorhaz commented 4 years ago

Yep, @enumag, I remember; just havin' some hot time on main job. I'll make a PR in a day or two.

kelunik commented 4 years ago