search

amphp / http

HTTP primitives which can be shared by servers and clients.
https://amphp.org/http
MIT License
88 stars 10 forks source link

Added check to discard phantom request cookies #18

Closed Bilge closed 1 year ago

Bilge commented 3 years ago

This is an improvement over the original implementation because the previous behaviour was to discard the entire set of request cookies if a phantom cookie was encountered, which is probably never the result we want.

Note this still buckles under a=1; (notice the trailing space). This could be solved by trimming the cookie before the comparison to the empty string, but this is left as an exercise for someone who gives more of a shit than I currently do.

Bilge commented 3 years ago

@kelunik What are we doing with this?

kelunik commented 1 year ago

Whoops, seems like I missed this, twice. Thanks!