search

amphp / mysql

An async MySQL client for PHP, optimizing database interactions with efficient non-blocking capabilities. Perfect for responsive, high-performance applications.
Other
358 stars 63 forks source link

travis: add mariadb. change to container build #17

Closed grooverdan closed 6 years ago

kelunik commented 9 years ago

Do we really need 12 instead of 3 test runs? We want to test our library, not MariaDB. Any specific reason why you add MariaDB to all those MySQL libraries?

grooverdan commented 9 years ago

As you're writing the protocol from specification it can't hurt to see if mariadb and mysql implement them the same and in a compatible way to this client implementation. Happy to cut this down to test each latest mariadb version against only one php version. What do you think?

kelunik commented 9 years ago

I don't really care, I just saw that you opened similar PRs to a few other projects today. @bwoebi Should we just merge it? As they're mostly running in parallel, it doesn't really matter IMO.

bwoebi commented 9 years ago

That PR adds the addons, but it doesn't actually run the tests on a mariadb instance? Or am I missing anything?

grooverdan commented 9 years ago

There is still a travis bug (travis-ci/travis-ci/issues/4569) which doesn't enable the plugin in pull requests. It does work really- https://travis-ci.org/grooverdan/mysql :-)

kelunik commented 6 years ago

@bwoebi Could you please close or merge this PR? Thanks.

grooverdan commented 6 years ago

updated to resolve merge conflicts by rebasing on master. Used newer mariadb versions. mariadb-5.5 removed as package wouldn't override existing mysql-5.6 service on travis infrastructure. There are some test failures - different flags output. Perhaps this is allowable?

https://travis-ci.org/grooverdan/mysql/jobs/302234121

grooverdan commented 6 years ago

CI all green. even php nightlys (though they are allowed failures)

trowski commented 6 years ago

@grooverdan Any idea how to avoid this error with a READ COMMITTED transaction? It only happens with mariadb 10.0. See the mariadb branch.

grooverdan commented 6 years ago

you could "set session sql_log_bin=0" before the transaction if you aren't using the binary log for anything.

trowski commented 6 years ago

Manually merged via fe96ba7aeb0d282d5f1ff12fee1a150e05b286c5.