search

amphp / mysql

An async MySQL client for PHP, optimizing database interactions with efficient non-blocking capabilities. Perfect for responsive, high-performance applications.
Other
359 stars 63 forks source link

Undefined index in unmapConnection #7

Closed kelunik closed 9 years ago

kelunik commented 9 years ago

Notice: Undefined index: 000000002f21b38f000000002e01fac2 in mysql/lib/Pool.php on line 242

There should be a check if that key exists.

bwoebi commented 9 years ago

How can I reproduce this bug? There shouldn't be a check, it's a bug somewhere else if the index isn't defined there.

kelunik commented 9 years ago

I don't really know, could be due to notebook energy saving state?

bwoebi commented 9 years ago

That could be the reason why a connection breaks, but not why this emits a notice...

kelunik commented 9 years ago

When does this method get called?

bwoebi commented 9 years ago

When a connection fails. (in config->restore callback and in the when() when it fails upon initialization).

douggr commented 9 years ago

I got it (I think).

From http://php.net/stream_socket_client

UDP sockets will sometimes appear to have opened without an error, even if the remote host is unreachable. The error will only become apparent when you read or write data to/from the socket. The reason for this is because UDP is a "connectionless" protocol, which means that the operating system does not try to establish a link for the socket until it actually needs to send or receive data.

So connecting to any reachable IP address might open the connection failing silently.

To reproduce, just connect to 127.0.0.1:any-closed-port.

douggr commented 9 years ago

Question, this should apply to amphp/mysql or rdlowrey/nbsock?

cc /@rdlowrey

edit: Somehow this affects artax too.

douggr commented 9 years ago

Also related to #5 perhaps?

kelunik commented 9 years ago

@douggr It's all TCP, I think only DNS uses UDP.

douggr commented 9 years ago

Good call.

Despite a valid stream is created, empty even, the connection may or may not be valid; you don't know until you read from it.

Since onRead() is called only within onInit() maybe this douggr/mysql@2cf671a fix the whole thing?

bwoebi commented 9 years ago

@douggr onRead() is the general callback for the read watcher, just the first read is in onInit(), which then invokes onRead(). … So, no.

kelunik commented 9 years ago

It's called every time the socket is readable, see https://github.com/douggr/mysql/blob/master/lib/Connection.php#L168

bwoebi commented 9 years ago

This bug was fixed in f50e75068