search

amphp / parallel-functions

Simplified parallel processing for PHP based on Amp.
https://amphp.org/parallel-functions
MIT License
271 stars 18 forks source link

docs/asset file points to non existing file/folder #23

Closed sci3ma closed 4 years ago

sci3ma commented 4 years ago

v1.0.0 docs/asset file points to .shared/asset which does not exist. .shared/asset seems to be outside of the lib. It makes failing my deployment flow because my strict policy checks permissions of all files. Besides that .shared/ folder is empty after installing the library.

rybakit commented 4 years ago

@sci3ma See https://github.com/amphp/byte-stream/issues/48.

sci3ma commented 4 years ago

Thanks @rybakit but unfortunately I'm not sure how it should help me.

kelunik commented 4 years ago

@sci3ma it removes the symlink from the release archives, so it prevents the issue you're seeing.

The directory is empty, because it's a git submodule.

sci3ma commented 4 years ago

Sorry to waste your time but still I'm confused. I have a problem with amphp/parallel-functions, not with amphp/byte-stream. Correct me if I'm wrong. Shoudl I install amphp/byte-sream to fix issue which is in amphp/parallel-functions?

rybakit commented 4 years ago

@sci3ma Just create a PR with a fix like in https://github.com/amphp/byte-stream/commit/6bbfcb6f47e92577e739586ba0c87e867be70a23 and ask @kelunik to merge it and tag a new release :)

sci3ma commented 4 years ago

@rybakit Couldn't you start with that answer at the beginning? :D thanks for your help. PR created https://github.com/amphp/parallel-functions/pull/24