search

amphp / parallel-functions

Simplified parallel processing for PHP based on Amp.
https://amphp.org/parallel-functions
MIT License
268 stars 18 forks source link

Update to php-cs-fixer v3 #30

Closed owenvoke closed 2 years ago

owenvoke commented 2 years ago

This updates to PHP-CS-Fixer 3.x, and applies style fixes from the updated version.

Note: It looks like this strips the \ prefix for global namespaced functions. This can be configured with the native_function_invocation rule, however this is classed as risky so I wasn't sure whether to include it. 👍🏻 Let me know.

kelunik commented 2 years ago

Thanks for the PR! This should really be done in https://github.com/amphp/php-cs-fixer-config/issues/6 instead and then use that package here. We've enabled risky rules, yes.

kelunik commented 2 years ago

There's a v2 branch for https://github.com/amphp/php-cs-fixer-config/tree/v2 now based on php-cs-fixer v3.

owenvoke commented 2 years ago

@kelunik, I've updated this to use the v2.x branch 👍🏻

kelunik commented 2 years ago

@owenvoke Thanks! :raised_hands: