search

amphp / websocket-client

Async WebSocket client for PHP based on Amp.
https://amphp.org/websocket-client
MIT License
148 stars 18 forks source link

Missing `$closeTimeout` property #4

Closed lt closed 8 years ago

lt commented 8 years ago

Not sure if the socket is being closed from the remote end, or the local end due to a timeout, but getting the following notice spam.

Notice: Undefined property: Amp\Websocket\Rfc6455Endpoint::$closeTimeout in vendor/amphp/websocket/lib/Rfc6455Endpoint.php on line 428
staabm commented 8 years ago

@bwoebi I guess we should assign null instead of unset the closeTimeout

bwoebi commented 8 years ago

Urgs, I always forget that unset() actually removes them :x … Will fix.