ampinzonv / BB2

BioBash UN official repository
Other
3 stars 1 forks source link

Duplicated fastq_to_fasta functions #15

Open ampinzonv opened 7 months ago

ampinzonv commented 7 months ago

CONTEXT fastq_to_fasta is a function that transforms a FASTQ file into a FASTA file. For this seqkit fq2fa is used. This function appears in two modules:

And appears tested in two unit tests:

Both under "success" status.

ISSUE

  1. The implementation of the same function in two different modules can be misguiding for future developments.
  2. It makes more sense to have this function in the BBformat module than in the BBfile oe.

SOLUTION

  1. Remove the BBfile::fastq_to_fasta from the file module.
  2. Remove the test_file_fastq_to_fasta script.
  3. Re-implement the bb_fastq_to_fasta executable so it uses the BBformat::fastq_to_fasta function.