search

amplab / graphx

Former GraphX development repository. GraphX has been merged into Apache Spark; please submit pull requests there.
https://github.com/apache/spark
Apache License 2.0
360 stars 103 forks source link

SVD++ demo #104

Closed jdk8 closed 10 years ago

AmplabJenkins commented 10 years ago

Can one of the admins verify this patch?

jegonzal commented 10 years ago

This is a very useful application, thanks for the PR! Two requests:

1) Can you make a version that takes the edges RDD (or even a graph) instead of the raw text file. 2) Can you add a basic unit test that generates a synthetic edge RDD and then runs the inference algorithm. For a reference collection of unit tests see https://github.com/amplab/graphx/blob/master/graph/src/test/scala/org/apache/spark/graph/AnalyticsSuite.scala

By doing this we can make the code more general and also have a way to verify that changes we make to the system don't affect the application.

jdk8 commented 10 years ago

Hi jegonzal, got it, I will make these changes later.

ankurdave commented 10 years ago

Jenkins, add to whitelist.

AmplabJenkins commented 10 years ago

One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5238/

AmplabJenkins commented 10 years ago

One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5240/

AmplabJenkins commented 10 years ago

All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5243/

AmplabJenkins commented 10 years ago

All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5245/

AmplabJenkins commented 10 years ago

One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5372/

AmplabJenkins commented 10 years ago

All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/5374/

jegonzal commented 10 years ago

This looks great! Thanks for the contribution.