search

amplab / graphx

Former GraphX development repository. GraphX has been merged into Apache Spark; please submit pull requests there.
https://github.com/apache/spark
Apache License 2.0
357 stars 103 forks source link

Fix failing "sbt/sbt publish-local" by adding a no-argument PrimitiveKeyOpenHashMap constructor #128

Closed adamnovak closed 10 years ago

adamnovak commented 10 years ago

Changing org.apache.spark.util.collection.PrimitiveKeyOpenHashMap to have a real no-argument constructor, instead of a one-argument constructor with a default value. The lack of a real no-argument constructor was causing "sbt/sbt publish-local" to fail thusly:

[error] /pod/home/anovak/build/graphx/core/src/main/scala/org/apache/spark/storage/ShuffleBlockManager.scala:172: not enough arguments for constructor PrimitiveKeyOpenHashMap: (initialCapacity: Int)(implicit evidence$3: ClassManifest[Int], implicit evidence$4: ClassManifest[Int])org.apache.spark.util.collection.PrimitiveKeyOpenHashMap[Int,Int]
[error]     private val mapIdToIndex = new PrimitiveKeyOpenHashMap[Int, Int]()
[error]                                ^
[info] No documentation generated with unsucessful compiler run
[error] one error found
[error] (core/compile:doc) Scaladoc generation failed
[error] Total time: 67 s, completed Jan 6, 2014 2:20:51 PM

In theory a no-argument constructor ought not to differ from one with a single argument that has a default value, but in practice there seems to be an issue.

AmplabJenkins commented 10 years ago

Can one of the admins verify this patch?

ankurdave commented 10 years ago

Jenkins, add to whitelist.

AmplabJenkins commented 10 years ago

One or more automated tests failed Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/10724/

ankurdave commented 10 years ago

Jenkins, retest this please.

AmplabJenkins commented 10 years ago

All automated tests passed. Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/GraphXPullRequestBuilder/10726/

ankurdave commented 10 years ago

Thanks. I don't understand why this happens, but it certainly is a problem (see #78), so I'm merging this.