search

amplab / keystone

Simplifying robust end-to-end machine learning on Apache Spark.
http://keystone-ml.org/
Apache License 2.0
470 stars 117 forks source link

Fixing VectorSplitter irregular block size issue and adding unit test. #208

Closed etrain closed 8 years ago

etrain commented 8 years ago

This adds a fix for the non-apply method in VectorSplitter which doesn't have a proper termination condition when the blocksize is not an exact multiple of the vector size.

Closes #188

shivaram commented 8 years ago

Sorry I should have done this in the same solvers PR. Code change LGTM. Some minor test comments

etrain commented 8 years ago

Fixed formatting issues and added a test.

etrain commented 8 years ago

good catch, thanks!

shivaram commented 8 years ago

LGTM