Adding logic to set OMP_NUM_THREADS appropriately

amplab / keystone

Simplifying robust end-to-end machine learning on Apache Spark.

http://keystone-ml.org/

Apache License 2.0

470 stars 117 forks source link

Closed etrain closed 8 years ago

etrain commented 8 years ago

Addresses #198

Tested locally on OSX in several combinations of situations, and verified that env variables were set as expected.

shivaram commented 8 years ago

Change looks fine. Can we test this on Linux on say a millennium machine before merging ?

etrain commented 8 years ago

Great - I will test on millennium this AM.

etrain commented 8 years ago

Apparrently [[ and -eq don't behave as expected with strings. Once that was fixed everything seems to work fine on both linux and osx.

shivaram commented 8 years ago

Cool. LGTM