amplab / snap

Scalable Nucleotide Alignment Program -- a fast and accurate read aligner for high-throughput sequencing data
https://www.microsoft.com/en-us/research/project/snap/
Apache License 2.0
287 stars 66 forks source link

Add missing return statement #118

Closed liubovch closed 5 years ago

liubovch commented 5 years ago

Hi! I was tracking down an error that occurred during the build of SNAP inside Debian:

    LandauVishkinTest:
    - equal strings: [OK]
    - prefixes: [OK]
    - non-equal strings: [OK]
    - overly distant strings: [OK]
    - CIGAR strings: [OK]

    EventTest:
    - many waiters: make[1]: *** [debian/rules:17: override_dh_auto_test] Segmentation fault

I have found that there is missing return that caused the segfault:

SNAPLib/Compat.cpp: In member function ‘bool SingleWaiterObjectImpl::destroy()’:
SNAPLib/Compat.cpp:1122:5: warning: no return statement in function returning non-void [-Wreturn-type]
     }
     ^
AmplabJenkins commented 5 years ago

Can one of the admins verify this patch?