blahah
commented
9 years ago Devs, is there anything in particular holding up this PR, and #32 and #47? These are all very small, simple changes that improve correctness or compatibility.
Closed blahah closed 9 years ago
blahah
commented
9 years ago Devs, is there anything in particular holding up this PR, and #32 and #47? These are all very small, simple changes that improve correctness or compatibility.
bolosky
commented
9 years ago Just that I don’t have a mac to test them on. I’ll eyeball them and hope it’s all OK.
From: Richard Smith-Unna [mailto:notifications@github.com] Sent: Wednesday, May 6, 2015 6:50 AM To: amplab/snap Subject: Re: [snap] fix OSX compilation by explicitly declaring flock as struct (fix #40) (#43)
Devs, is there anything in particular holding up this PR, and #32https://github.com/amplab/snap/pull/32 and #47https://github.com/amplab/snap/pull/47? These are all very small, simple changes that improve correctness or compatibility.
— Reply to this email directly or view it on GitHubhttps://github.com/amplab/snap/pull/43#issuecomment-99467130.
bolosky
commented
9 years ago I merged #47. We’re about to integrate dev to master, so since #47 includes #32, I’ll just skip it for now.
--Bill
From: Richard Smith-Unna [mailto:notifications@github.com] Sent: Wednesday, May 6, 2015 6:50 AM To: amplab/snap Subject: Re: [snap] fix OSX compilation by explicitly declaring flock as struct (fix #40) (#43)
Devs, is there anything in particular holding up this PR, and #32https://github.com/amplab/snap/pull/32 and #47https://github.com/amplab/snap/pull/47? These are all very small, simple changes that improve correctness or compatibility.
— Reply to this email directly or view it on GitHubhttps://github.com/amplab/snap/pull/43#issuecomment-99467130.
Test FAILed. Refer to this link for build results (access rights to CI server needed): https://amplab.cs.berkeley.edu/jenkins//job/snap-prb/6/ Test FAILed.