search

amplab / snap

Scalable Nucleotide Alignment Program -- a fast and accurate read aligner for high-throughput sequencing data
https://www.microsoft.com/en-us/research/project/snap/
Apache License 2.0
288 stars 66 forks source link

fix EventTest, single waiter #45

Closed blahah closed 9 years ago

blahah commented 9 years ago

As mentioned here, there is an ongoing bug in EventTest. This is causing tests to fail for my PRs ;)

bolosky commented 9 years ago

That's fixed in dev, next time we reintegrate it'll be in master.

Sent from my Windows Phone

From: Richard Smith-Unnamailto:notifications@github.com Sent: ý1/ý15/ý2015 1:37 PM To: amplab/snapmailto:snap@noreply.github.com Subject: [snap] fix EventTest, single waiter (#45)

As mentioned herehttps://groups.google.com/forum/#!searchin/snap-user/test/snap-user/t70z5xDQUA4/GlrXYGAaW0wJ, there is an ongoing bug in EventTesthttps://github.com/amplab/snap/blob/dev/tests/EventTest.cpp. This is causing tests to fail for my PRs ;)

— Reply to this email directly or view it on GitHubhttps://github.com/amplab/snap/issues/45.

blahah commented 9 years ago

that's odd, because my PRs are based on dev HEAD, so surely that test shouldn't be failing in them?

bolosky commented 9 years ago

Fixed in 1.0dev.68. I swear I already did this once, but somehow the code got lost and not checked in.