search

amplab / training

Training materials for Strata, AMP Camp, etc
150 stars 121 forks source link

scala bigrams exercise #101

Open jowens opened 11 years ago

jowens commented 11 years ago

"output a set of all “word1_word2” pairs that occur in sequence in the input string"

I don't like "in sequence". If you use Set, they won't be in sequence. I would remove "in sequence".

Also, I'd give the prototype for the function (makes it easier on new Scala users).

atalwalkar commented 11 years ago

Hi John,

These are good points -- thanks for the feedback!

-Ameet

On Fri, Aug 30, 2013 at 11:59 AM, John Owens notifications@github.comwrote:

"output a set of all “word1_word2” pairs that occur in sequence in the input string"

I don't like "in sequence". If you use Set, they won't be in sequence. I would remove "in sequence".

Also, I'd give the prototype for the function (makes it easier on new Scala users).

— Reply to this email directly or view it on GitHubhttps://github.com/amplab/training/issues/101 .