Graceful Coordination Error-handling

amplab / velox-modelserver

http://amplab.github.io/velox-modelserver/

Apache License 2.0

110 stars 26 forks source link

Graceful Coordination Error-handling #53

Closed tomerk closed 9 years ago

tomerk commented 9 years ago

Fix bugs in the Velox retrain coordination (e.g. always releasing the lock on a retrain call even if it isn't being held) and make sure to handle failures gracefully.

dcrankshaw commented 9 years ago

How does #54 address this? The lock release is still in the finally clause right?

tomerk commented 9 years ago

The finally clause was moved to only occur if the lock was acquired.

dcrankshaw commented 9 years ago

Oh great. Closing.