search

amplab / velox-modelserver

http://amplab.github.io/velox-modelserver/
Apache License 2.0
110 stars 26 forks source link

Automatically forward requests to correct partition #61

Closed dcrankshaw closed 9 years ago

tomerk commented 9 years ago

@dcrankshaw How should this be represented via the timer metrics?

dcrankshaw commented 9 years ago

Good question. I think the timer should record time elapsed between request received and response sent. So if we have a situation where client sends request to A which forwards request to B, As timer should include the time to forward the request to B and receive the response, and Bs timer should record timing as normal.

tomerk commented 9 years ago

Okay, but that also means the aggregated counts for # of queries across all nodes wouldn't be accurate. Is that alright?

dcrankshaw commented 9 years ago

Yeah that's fine. For these metrics I think we're more interested in machine workload than application workload.

dcrankshaw commented 9 years ago

Fixed by #64