search

ample / ample_assets

Drag and drop file management for Rails.
http://ample.github.com/ample_assets
MIT License
2 stars 2 forks source link

Cannot drag file attachments. #18

Closed tcmacdonald closed 12 years ago

uhlenbrock commented 12 years ago

Uploading non-image assets results in an immediate 500 error since the create action is trying to render the file partial, but the file partial does not take non-images into account. (https://github.com/tcmacdonald/ample_assets/blob/master/app/views/ample_assets/files/_file.html.erb)

uhlenbrock commented 12 years ago

The div is not draggable since the node is empty. It will need a non-breaking space at the very least.

uhlenbrock commented 12 years ago

I also think it may be easier (and better) to use images for the various non-image types versus background images. It would automatically fix the underlying issue here as well as provide one canonical place for all asset thumbnails (the model). Currently exceptions for non-image icons have to be coded in the _file partial and the toolbar javascript.

tcmacdonald commented 12 years ago

Agreed. Actually working on this problem now and that was my conclusion as well.