ampledata / aprs

Python APRS Module
https://github.com/ampledata/aprs
Other
95 stars 53 forks source link

Sends LF+CR instead of CR+LF at line end #17

Closed hessu closed 7 years ago

hessu commented 7 years ago

Hi,

Minor bug: The APRS-IS line termination is CR+LF (spec: http://aprs-is.net/Connecting.aspx). class TCP(APRS) transmits LF+CR instead:

https://github.com/ampledata/aprs/blob/master/aprs/classes.py#L382

Most APRS-IS servers will currently accept this, but some might not.

The receiving side seems to have this right: https://github.com/ampledata/aprs/blob/master/aprs/classes.py#L407

ampledata commented 7 years ago

Thank you so much for the fix, I've merged it into the python3_support branch!