search

amplication / docs

Amplication docs
https://docs.amplication.com
Apache License 2.0
17 stars 62 forks source link

Sync With GitHub updates #300

Closed dericksozo closed 1 year ago

dericksozo commented 1 year ago

(docs): Adding the necessary content and screenshots for the Sync Wit…

dericksozo commented 1 year ago

Thanks a lot @GreenMachine01 for the feedback. All of this is implemented in the latest commit. Please let me know if there's anything else I can fix.

GreenMachine01 commented 1 year ago

@dericksozo I didn't see yet your latest changes. But I got feedback from Yuval that we should aim to avoid screenshots with highlights. so ignore one of my feedbacks on this matter.

Edited - I just saw it and I really like it. ill run it by Yuval and update you on this point.

GreenMachine01 commented 1 year ago

@dericksozo I had a discussion with Yuval about using screenshots in our docs and we came to the agreement that in general we should minimize it to avoid the constant need to update assets and assuming we are building good UX/UI which by instructions the user should have enough info to easily execute what he needs to do.

so let's just be critical on when we decide to add screenshots and even if we decide to add let's be critical about if we need to highlight components.

dericksozo commented 1 year ago

Hey @GreenMachine01, I removed 2 screenshots which could be considered unnecessary. The rest of them help the page, but please let me know your thoughts.

dericksozo commented 1 year ago

Thanks @GreenMachine01 and @overbit, these changes are now implemented.