search

amplication / docs

Amplication docs
https://docs.amplication.com
Apache License 2.0
17 stars 62 forks source link

Docs: `before` and `after` plugin event notes #369

Closed dericksozo closed 1 year ago

dericksozo commented 1 year ago

(docs): Adding some notes and best practices regarding before and after events for plugins that developers should be aware of.

This PR takes care of Issue #348.

dericksozo commented 1 year ago

@GreenMachine01, I'm succinctly explaining these as "Best Practices" instead of "Warnings". What are your thoughts?

GreenMachine01 commented 1 year ago

@dericksozo It doesn't feel like a "best practice". how about "Cautionary Guidelines" or "Cautions for using 'before' and 'after' Events"?

dericksozo commented 1 year ago

@GreenMachine01 @mulygottlieb What are your thoughts on this one? Does it look good?

GreenMachine01 commented 1 year ago

@dericksozo LGTM