feat(client): updated default http client to retry network or rate limited errors - Githubissues

amplience / dc-management-sdk-js

Amplience Dynamic Content Management SDK

https://amplience.github.io/dc-management-sdk-js/

Other

45 stars 14 forks source link

feat(client): updated default http client to retry network or rate limited errors #151

Closed Benj0s closed 1 year ago

Benj0s commented 1 year ago

Pull request checklist

Please check if your PR fulfills the following requirements:

[x] Build (npm run build) was run locally and any changes were pushed
[x] Tests (npm run test) for the changes have been added (for bug fixes / features)
[x] Docs (npm run doc) have been reviewed and added / updated if needed (for bug fixes / features)
[x] PR title and git commit messages conform to the conventionalcommits specification

Pull request type

Please check the type of change your PR introduces:

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, renaming)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] Documentation content changes
[ ] Other (please describe):

What is the current behaviour?

When request returns a "retryable" error there is not attempt to retry the request.

What is the new behaviour?

Added retry behaviour for the following errors:

Network errors
5xx errors on an idempotent request (GET, HEAD, OPTIONS, PUT or DELETE)
429 errors

The client is configured to retry error requests 3 times using exponential backoff.

Does this introduce a breaking change?

[ ] Yes
[x] No

Other information

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 6694355901

5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.03%) to 95.596%

Totals
Change from base Build 6694350750:	0.03%
Covered Lines:	966
Relevant Lines:	983

💛 - Coveralls