search

amplify-edge / sys

system
Apache License 2.0
0 stars 2 forks source link

History, Navigation & Routing Issues (Flutter) #114

Open alexadhy opened 3 years ago

alexadhy commented 3 years ago

Favicon Issue(s)

screenshot_2021-01-11-064323

Navigation (Routing) issues

  1. Navigation stack seems to be restarted / cleaned on refresh (to be confirmed by @AppliNH )

Related Issue: https://github.com/flutter/flutter/issues/59277

Steps to reproduce:
  1. On mobile (to be confirmed on desktop), navigation can get to unrelated routes / icons does not reflect actual route selected

photo_2021-01-11_06-48-27

Steps to reproduce:
  1. Survey Page needs to have both projectId and orgId in its url param
AppliNH commented 3 years ago

@gutterbacon we have to discuss about keeping the modular routing or migrate to the regular one. Unless we fix this... Except using a Provider pattern (which might be overkill ?), I don't see how to proceed

joe-getcouragenow commented 3 years ago

Adding other cross needs of the router that flutter modular provided to us, so you know the design needs before you break things.

Both of the above were verified to work ages ago, however we don't have the code in CI that shows this working liek we had before.

This is why we need dummy modules and dummy apps actually. So that we can verify that the Modular architecture works and keeps working. So once we get Booty, CI, CD running smooth, we should introduce dummy apps and modules so we can verify this works.

To test this we need to use some of the tools in Booty like screen shot, and other automation tools as part of E2E testing. E2E works well with dummy modules and apps because the data is small and it verifies the architecture.