hostedZonePrivate parameter is not honoured in v6.2.0

[Rowan002]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or "me too" comments, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Bug Report

Error Description Since v6.2.0 introduction of the splitHorizonDns parameter and subsequent refactoring, the hostedZonePrivate parameter is no longer honoured when filtering target hosted zones.

Command Run sls deploy

Domain Manager Configuration

custom:
  customDomain:
    domainName: ${self:custom.domainName.full}
    hostedZonePrivate: true
    certificateName: ${self:custom.domainName.full}
    basePath: ''
    stage: ${self:custom.stage}
    createRoute53Record: true
    endpointType: regional
    autoDomain: true

Versions

• Domain Manager version(s): v6.2.0
• Node/npm version: node 16
• Serverless Version: 3.24.1
• Lambda Code: .Net Core

Possible Solution The following line should specify the second argument for hostedZonePrivate. https://github.com/amplify-education/serverless-domain-manager/blob/master/src/aws/route53-wrapper.ts#L37

const route53HostedZoneId = await this.getRoute53HostedZoneId(domain); const route53HostedZoneId = await this.getRoute53HostedZoneId(domain, domain.hostedZonePrivate);

This seems to have been introduced on this commit: https://github.com/amplify-education/serverless-domain-manager/commit/e0e67d798827f585784d4683326514a46d1c240c#diff-343342879313fd7673a6f0651848f7ed358a2b98e55f0ed4554fcf35f0ba5ee8