fix: fix getCustomDomainInfo function to different APIGateway versions

amplify-education / serverless-domain-manager

Serverless plugin for managing custom domains with API Gateways.

MIT License

941 stars 232 forks source link

Closed aalongkott closed 1 year ago

aalongkott commented 1 year ago

Fixes #536 Description of Issue Fixed

Fix getCustomDomainInfo function to use different APIGateway versions according to endpointType and securityPolicy

Changes proposed in this pull request:

In getCustomDomainInfo function, using APIGateway version 1 when endpointType == "EDGE" and securityPolicy == "TLS_1_0". Otherwise, using APIGateway version 2.

rddimon commented 1 year ago

Hi @aalongkott

Thank you for your contribution! Could you please also update unit tests?

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
0.0% Duplication

aalongkott commented 1 year ago

Hello @rddimon

I have fixed the unit tests according to the bugs. Please review and if the coverage does not match your requirements, please tell me.