search

amplify-education / serverless-domain-manager

Serverless plugin for managing custom domains with API Gateways.
MIT License
937 stars 234 forks source link

chore: enable compatibility with Serverless Framework v4 #633

Closed czubocha closed 2 months ago

czubocha commented 3 months ago

Fixes #632

Description of Issue Fixed Users can't use serverless-domain-manager with Serveerless Framework v4.

Changes proposed in this pull request:

Add ^4.0.0 to peerDependencies

czubocha commented 3 months ago

Hi, @rddimon! Could you take a look at this PR and the proposed changes to peerDependencies, please?

czubocha commented 2 months ago

Hi @rddimon and @jcoaks, since this change has been approved, could you please merge this PR and release a new plugin version?

cbschuld commented 1 month ago

Hey @rddimon & @jcoaks any chance there is an updated release coming soon that will push out support for v4? I see the updates in main but the latest release is obviously from back in March. Thanks for help/work/tooling!

aareyes96 commented 1 month ago

Hello. I have same issue. Is possible to use the plugin ??? I'm using "serverless": "^4.1.21"

npm ERR! Could not resolve dependency: npm ERR! peer serverless@"^2.60 || ^3.0.0" from serverless-domain-manager@7.3.8 npm ERR! node_modules/serverless-domain-manager npm ERR! serverless-domain-manager@"*" from the root project npm ERR! npm ERR! Fix the upstream dependency conflict, or retry npm ERR! this command with --force or --legacy-peer-deps npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

ashley-jisc commented 1 month ago

Hi @rddimon & @jcoaks This error still shows for the latest version of serverless ~4.1.21