amplify-education / serverless-domain-manager

Serverless plugin for managing custom domains with API Gateways.
MIT License
937 stars 234 forks source link

Release 7.4.0 #635

Closed rddimon closed 1 month ago

rddimon commented 2 months ago

Description of Issue Fixed A new release with small improvements

Changes proposed in this pull request:

threes-was-taken commented 1 month ago

Hi @rddimon Do you have an idea when this release is planned? Looking forward to this one 🙌🏼

franrivero commented 1 month ago

We have the same issue when we try to use sls version 4 with domain manager, do you have any fix of this?

plo2 commented 1 month ago

Good afternoon, hope you are doing well, we are facing the same problem, any ETR?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

rddimon commented 1 month ago

Hi there, Sorry for the delay We are going to release it today

amplify-self-hosted-runners[bot] commented 1 month ago
Check Name Conclusion Summary Output
SonarCloud Code Analysis success Quality Gate passed output
Codacy Static Code Analysis success Your pull request is up to standards! output
Mend Security Check success Security Report output
Mend License Check success License Report output
test (14.x) success test (14.x) output
test (16.x) success test (16.x) output
test (18.x) success test (18.x) output
test (20.x) success test (20.x) output
franrivero commented 1 month ago

Hi all,

We still have the issue, because the upgrade to version 7.4.0 has a serverless v2 dependency. When I run npm i serverless-domain-manager, that installed the last version, and when you search into dependencies, you can see:

  "peerDependencies": {
    "serverless": ">=2.60"

If you try upgrade serverless, you cannot move forward, the issue doesn't seem to be solved.

Thanks in advance