search

amplify-education / serverless-domain-manager

Serverless plugin for managing custom domains with API Gateways.
MIT License
938 stars 234 forks source link

Multiple domain support #88

Closed JamesKyburz closed 4 years ago

JamesKyburz commented 6 years ago

Would you be interested in a pull request that adds support for multiple domains (per stage).

That is I would like www.example.com and example.com to point to the same aws lambda.

Unless this is already possible?

captainsidd commented 6 years ago

Hi there! Is this possibly what you are looking for?

JamesKyburz commented 6 years ago

@sidgonuts Thanks, I need that too :) But I also need multiple domains per stage too.

I will be registering multiple domains pointing to the same lambda for each stage. All this to achieve redirects from say example.com to www.example.com.

thejuan commented 6 years ago

I'd like this too. I use AWS linked account per environment and use domain delegation.

Root Account: api.example.com CNAME api.master.example.com

Master Account: api.master.example.com CNAME {apigateway regional domain}

Each of my service stages need two custom domains

Vadorequest commented 6 years ago

I need this as well, because I deploy under one kinda private domain, under the company name, and I also deploy in my customer's domain which simply proxy the requests to my main API Gateway.

I wonder if I can use both this plugin AND a an API Gateway custom domain resource? https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-apigateway-domainname.html

If that's possible to use both (have severless-domain-manager to configure the main domain (company) and have the proxy domain deployed through the SLS resources? If so it also fix my issue.

captainsidd commented 6 years ago

@JamesKyburz it seems like there's enough people that would like this functionality. If you would like to make a pull request for that, that'd be great. Thanks!

et304383 commented 6 years ago

@JamesKyburz are you still looking to add a PR to support this? We need this too.

kidculli commented 5 years ago

We need this as well

yilinjuang commented 4 years ago

Any updates? Would be great to have this

ricardovf commented 4 years ago

This would be great for our use case too!

ConradKurth commented 4 years ago

@ricardovf @frankyjuang @kidculli I made a PR with this change if you wish to use it!

s-kris commented 4 years ago

This would be great use case, waiting.

casualuser commented 4 years ago

It look like https://github.com/amplify-education/serverless-domain-manager/pull/327 is pending for 5 months already. Is there something real preventing merge and deliver a such a high demand feature?