amplify-education / serverless-vpc-discovery

Serverless plugin for discovering VPC / Subnet / Security Group configuration by name.
MIT License
38 stars 15 forks source link

Allows looking up subnet OR security group...doesn't require both #30

Closed corydorning53 closed 3 years ago

corydorning53 commented 3 years ago

Originally forked from env0 which includes pr 18 and 19 and disable: https://github.com/env0/serverless-vpc-discovery/releases/tag/1.0.14-pr-18-19-plus-disable-rerelease

Didn't update the unit tests because i've only really worked with jest. happy to make any changes if needed.

corydorning53 commented 3 years ago

End user would be required to specify the one they didn't lookup. In my case, the security group is created in serverless so i was able to just reference it in my serverless.yml.

rddimon commented 3 years ago

Close it as it's already implemented in the latest version