fix: do not fetch advertising Id if adid tracking is disabled

[falconandy]

Additional note: in Android-Kotlin default value for limitAdTrackingEnabled is true, in Amplitude-Android - false

• https://github.com/amplitude/Amplitude-Kotlin/blob/main/common-android/src/main/java/com/amplitude/common/android/AndroidContextProvider.kt#L51
• https://github.com/amplitude/Amplitude-Android/blob/main/src/main/java/com/amplitude/api/DeviceInfo.java#L56

Maybe if adid tracking is disabled limitAdTrackingEnabled should be null.

UPD: for some reason IdentifyInterceptTest fail in CI (work locally).

Checklist

• [x] Does your PR title have the correct title format?
• Does your PR have a breaking change?: no

[justin-fiedler]

Additional note: in Android-Kotlin default value for limitAdTrackingEnabled is true, in Amplitude-Android - false

Thanks for calling this out. I think this is because ADID usage is no longer recommended, but was at the time of Amplitude-Android's initial release. We probably kept the the legacy SDK as-is for backwards compatibility but changed it in the new SDK along with other breaking changes.

cc @qingzhuozhen

[falconandy]

@justin-fiedler

Can you please try fixing the Identify tests some more pray I really want them to be reliable in CI so we can be confident in releases.

Fixed (removed global mocking from other tests). Some other tests are still unstable but re-run helps.

@Mercy811

Want to confirm that to disable tracking ADID, the usage remains the same but ADID is not fetched by the SDK.

yes, with trackingOptions.disableAdid() the SDK shouldn't fetch ADID

[github-actions[bot]]

:tada: This PR is included in version 1.9.2 :tada:

The release is available on:

• GitHub release
• v1.9.2

Your semantic-release bot :package::rocket: