amplitude / Amplitude-Kotlin

Amplitude Kotlin SDK

MIT License

27 stars 10 forks source link

fix: race condition when setting device id in android #177

Closed justin-fiedler closed 5 months ago

justin-fiedler commented 5 months ago

Summary

https://amplitude.atlassian.net/browse/AMP-89527

Error

amplitude.getDeviceId() was returning null after await amplitude.isBuilt().
e.g. amplitude.isBuilt.invokeOnCompletion { amplitude.getDeviceId() == null); }

Fix

deviceId is now always set before isBuilt() is true

val amplitude = Amplitude(Configuration(...))
amplitude.isBuilt.invokeOnCompletion {
assertNotNull(amplitude.getDeviceId());
}

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?: No

github-actions[bot] commented 5 months ago

:tada: This PR is included in version 1.14.0 :tada:

The release is available on:

GitHub release
v1.14.0

Your semantic-release bot :package::rocket: