search

amplitude / Amplitude-Kotlin

Amplitude Kotlin SDK
MIT License
27 stars 10 forks source link

feat(upload): Accept HTTP 200 responses with empty body #184

Closed amezcua closed 4 months ago

amezcua commented 4 months ago

Summary

When using a third party server, we may encounter valid HTTP 200 responses that do not include a JSON body.

In the current SDK it is assumed that the response always has a JSON form and the request fails otherwise even though the response code is 200.

The failure is due to the creation of a JSONObject(responseBody) object that is passed to the function that creates the HTTP response. If that responseBody is null, empty or does not contain a json string, that call will throw an exception and the request is considered a failure.

In this change, if the response is null or empty, it is still passed to the function that creates the response, and, if it is a 200 response, it will be considered a successful response.

This behavior is equivalent to the behavior of the Amplitude Swift SDK, that accepts empty responses (https://github.com/amplitude/Amplitude-Swift/blob/35f253db41cf68d220390946c7ad7f344665d763/Sources/Amplitude/Utilities/HttpClient.swift#L35)

Checklist

amezcua commented 4 months ago

Changes included in https://github.com/amplitude/Amplitude-Kotlin/pull/185 (thanks!) closing this one.