search

amplitude / Amplitude-Kotlin

Amplitude Kotlin SDK
MIT License
27 stars 10 forks source link

Make com.amplitude.android.Amplitude return com.amplitude.core.platform.Timeline #203

Open asherepenko opened 2 weeks ago

asherepenko commented 2 weeks ago

Right now android's `Amplitude uses android's package Timeline, wich is final and can't be extended:

    override fun createTimeline(): com.amplitude.android.Timeline {
        return Timeline(configuration.sessionId).also { it.amplitude = this }
    }

It either has to be com.amplitude.core.platform.Timeline or com.amplitude.android.Timeline should be open class

Expected Behavior

Current Behavior

Possible Solution

Steps to Reproduce

1. 2. 3. 4.

Environment

izaaz commented 1 week ago

@asherepenko - can you please share what you're trying to do by extending the Timeline class? I can check if we can make that class open but wanted to understand the usecase to see if there are other ways the same functionality can be achieved.