amplitude / Amplitude-Kotlin

Amplitude Kotlin SDK
MIT License
28 stars 11 forks source link

fix: move session-specific logic from ContextPlugin to avoid race conditions #86

Closed falconandy closed 2 years ago

falconandy commented 2 years ago

Summary

Session-specific logic moved from ContextPlugin to avoid race conditions

Checklist

secure-code-warrior-for-github[bot] commented 2 years ago

Micro-Learning Topic: Race condition (Detected by phrase)

Matched on "race condition"

What is this? (2min video)

A race condition is a flaw that produces an unexpected result when the timing of actions impact other actions.

Try a challenge in Secure Code Warrior

falconandy commented 2 years ago

@qingzhuozhen A test was added. I need to change some session-related logic to make it more deterministic to be able to test it.

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.4.5 :tada:

The release is available on:

Your semantic-release bot :package::rocket: