amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude
MIT License
67 stars 20 forks source link

fix(retry): miscellaneous improvements to the default retry mechanisms #120

Open kelvin-lu opened 3 years ago

kelvin-lu commented 3 years ago

Summary

Props to @yuhao900914 (and I assume @dantetam in collaboration writing the Java SDK) for doing a critical reading of the logic in the retry mechanisms.

Fixes a couple of logical bugs that could result in errors down the line:

Checklist

ajhorst commented 3 years ago

@kelvin-lu is this PR still valid?