fix: Simplify sendEventsWithRetry promise declaration

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude

MIT License

67 stars 20 forks source link

fix: Simplify sendEventsWithRetry promise declaration #131

Closed tevanko closed 3 years ago

tevanko commented 3 years ago

Summary

Removes initialization of "response" variable since the initial value is always overwritten.

Checklist

[ ] Does your PR title have the correct title format?
Does your PR have a breaking change?:

tevanko commented 3 years ago

@ajhorst Don't see how to mark you as a reviewer on this one so mentioning you here.

lgtm-com[bot] commented 3 years ago

This pull request introduces 1 alert and fixes 1 when merging 22b235e490cbab26b01be2f7a72df74312917fcc into a6d353de0fb262b8cd9ff4d74e46a99c3c4b1a9e - view on LGTM.com

new alerts:

1 for Unused variable, import, function or class

fixed alerts:

1 for Useless assignment to local variable

ajhorst commented 3 years ago

@tevanko that looks like a permissions issue, working on getting that resolved for you now

Looks like removing that code now means you have an unused import in that file, so you should take that out as well

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 3c9184d9d04eeb64a1381a053a267b4324d88cb4 into a6d353de0fb262b8cd9ff4d74e46a99c3c4b1a9e - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable

lgtm-com[bot] commented 3 years ago

This pull request fixes 1 alert when merging 4bce6f74ca8d149ca6e4fb00f1449e61b3e69484 into a6d353de0fb262b8cd9ff4d74e46a99c3c4b1a9e - view on LGTM.com

fixed alerts:

1 for Useless assignment to local variable