fix(Identify): Ensure boolean is allowed as a valid property value

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude

MIT License

67 stars 20 forks source link

fix(Identify): Ensure boolean is allowed as a valid property value #147

Closed akosel closed 3 years ago

akosel commented 3 years ago

Summary

Fixes https://github.com/amplitude/Amplitude-Node/issues/116. There was another PR which added boolean as a valid type, but it didn't fix the core problem. This PR does and updates the tests to account for boolean as a valid value type.

Here is the original issue that was reported: https://github.com/amplitude/Amplitude-Node/issues/116

Checklist

[ x ] Does your PR title have the correct title format?
Does your PR have a breaking change?: No

qingzhuozhen commented 3 years ago

Hi @akosel good catch on this, can you fix the lint error in this PR? I guess the test build failed for that.

akosel commented 3 years ago

Hi @akosel good catch on this, can you fix the lint error in this PR? I guess the test build failed for that.

Thank you, I think I fixed it.

qingzhuozhen commented 3 years ago

Hi @akosel Thank you. I believe the lint error is fixed now, just now the test seems need some fix.

akosel commented 3 years ago

Ah, yeah, it was a parenthesis in the wrong place. I believe this should do it :crossed_fingers:

qingzhuozhen commented 3 years ago

Thanks @akosel, the build seems passing now