search

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude
MIT License
67 stars 20 forks source link

feat(transport): Allow using a custom port in URI #158

Closed ekanth closed 2 years ago

ekanth commented 2 years ago

Summary

Allow using a custom port in the URI. The code changes add support for extracting the port from the URI and setting it if one is given.

Our use-case: we proxy requests to Amplitude through our own endpoint. So in dev environment, it is helpful to be able to override the port in the URI.

Checklist

kevinpagtakhan commented 2 years ago

@ekanth Thanks for submitting a PR! We'll have someone review your PR in the next few days.

ekanth commented 2 years ago

Thank you @kevinpagtakhan for approving this. Would you or someone with write access to the repo help merge it as well?

ekanth commented 2 years ago

@kevinpagtakhan, when would a new release be published to npm with this change? I see the @amplitude-sdk-bot setting up to release 1.9.3 last Friday, but don't see any updates yet at @amplitude/node.

yuhao900914 commented 2 years ago

We use Github action to do the release, however, I saw the publish to npm section failed for some reason. Will check it soon and let you know when it's published to npm.

yuhao900914 commented 2 years ago

@ekanth we just fixed the release process. Please check the 1.9.2 on both github and npm . Thanks @kevinpagtakhan

ekanth commented 2 years ago

Thank you @yuhao900914!