search

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude
MIT License
69 stars 20 forks source link

maj tslib to next major #176

Closed kopax-polyconseil closed 2 years ago

kopax-polyconseil commented 2 years ago

Expected Behavior

When building our web application, we found multiple copy of tslib because this module us the old version 1.x of tslib

Current Behavior

I expect to dedupe tslib package

Possible Solution

Upgrade tslib

Steps to Reproduce

## static/js/2.f752eb41.chunk.js
tslib (Found 2 resolved, 2 installed, 13 depended. Latest 2.3.1.)
  1.14.1
    ~/@amplitude/utils/~/tslib
      * Dependency graph
        PassCulture@1.200.0 -> amplitude-js@^8.16.1 -> @amplitude/utils@^1.0.5 -> tslib@^1.9.3
      * Duplicated files in static/js/2.f752eb41.chunk.js
        tslib/tslib.es6.js (S, 10845)

  2.3.1
    ~/tslib
      * Dependency graph
        PassCulture@1.200.0 -> @fingerprintjs/fingerprintjs@^3.3.0 -> tslib@^2.0.1
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/analytics-compat@0.1.9 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/analytics@0.7.8 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/app-compat@0.1.22 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/component@0.5.13 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/logger@0.3.2 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/util@1.5.2 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/firestore-compat@0.1.17 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/firestore@3.4.8 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/installations@0.5.8 -> tslib@^2.1.0
        PassCulture@1.200.0 -> firebase@^9.6.11 -> @firebase/remote-config@0.3.7 -> tslib@^2.1.0
      * Duplicated files in static/js/2.f752eb41.chunk.js
        tslib/tslib.es6.js (S, 12348)

* Understanding the report: Need help with the details? See:
  https://github.com/FormidableLabs/inspectpack/#diagnosing-duplicates
* Fixing bundle duplicates: An introductory guide:
  https://github.com/FormidableLabs/inspectpack/#fixing-bundle-duplicates

Environment

irrelevant

dnshi commented 2 years ago

@kopax-polyconseil Thanks for reporting the issue. From the package.json file, we don't have tslib.js library as a dependency.

Which version of the Amplitude Node SDK do you use? Thanks.

kevinpagtakhan commented 2 years ago

tslib is listed as a package dependency so it can be found in packages/*/package.json

kopax-polyconseil commented 2 years ago

It has to be a sub deps in this case, it is in the logs: amplitude-js@^8.16.1 -> @amplitude/utils@^1.0.5 -> tslib@^1.9.3, so check the utils package.json

what version we use is also in the logs, we use amplitude-js@^8.16.1

kopax-polyconseil commented 2 years ago

We forced with a resolution in the package.json and it seems ok, perhaps you can just bump it and release a new version of those two packages?

kopax-polyconseil commented 2 years ago

After upgrading to 8.20.0, we still have the issue. I presume this is because the official repo of the package we are using is not amplitude-node but amplitude-js:

tslib (Found 2 resolved, 2 installed, 13 depended. Latest 2.3.1.)
  1.14.1
    ~/@amplitude/utils/~/tslib
      * Dependency graph
        PassCulture@1.203.0 -> amplitude-js@^8.20.0 -> @amplitude/utils@^1.0.5 -> tslib@^1.9.3
      * Duplicated files in static/js/2.9ac217bd.chunk.js
        tslib/tslib.es6.js (S, 10845)

  2.3.1
    ~/tslib
      * Dependency graph
        PassCulture@1.203.0 -> @fingerprintjs/fingerprintjs@^3.3.0 -> tslib@^2.0.1
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/analytics-compat@0.1.9 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/analytics@0.7.8 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/app-compat@0.1.22 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/component@0.5.13 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/logger@0.3.2 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/app@0.7.21 -> @firebase/util@1.5.2 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/firestore-compat@0.1.17 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/firestore@3.4.8 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/installations@0.5.8 -> tslib@^2.1.0
        PassCulture@1.203.0 -> firebase@^9.6.11 -> @firebase/remote-config@0.3.7 -> tslib@^2.1.0

Thank you for adressing the issue but I will have to reopen it on the other repo