chore(lint): Configure all the workspaces to use eslint configurations

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude

MIT License

67 stars 20 forks source link

chore(lint): Configure all the workspaces to use eslint configurations #54

Closed kelvin-lu closed 4 years ago

kelvin-lu commented 4 years ago

Summary

Adheres to the tslint recommended eslint rules

only a few instances of floating promises where necessary (in setTimouts, and also to start the retry logic) Move the fromHttpCode to mapHttpCodeToStatus in utils

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?:

kelvin-lu commented 4 years ago

@jooohhn we should - there are some things to resolve. it seems the eslint and the base prettier configs are out of sync and fighting each other (try pulling the branch and looking at the types/src/response.ts file)