search

amplitude / Amplitude-Node

Server-side Node.js SDK for Amplitude
MIT License
67 stars 20 forks source link

ci(lint): add eslint prettier plugin, eslint/prettier CI step #95

Closed kelvin-lu closed 3 years ago

kelvin-lu commented 3 years ago

Summary

Adds the prettier plugin which stops eslint and prettier from fighting in certain files.

Adds ESLint + Prettier as a breaking step in PR Validation, as well as cleans up a few eslint issues.

Next step is to get Prettier + ESLint working well with Husky (+ whatever the best practice is in Lerna/monorepos)

Checklist