fix: add support for Decimal property values

amplitude / Amplitude-Swift

Native iOS/tvOS/macOS/watchOS SDK

MIT License

26 stars 20 forks source link

fix: add support for Decimal property values #187

Closed doctorcooper closed 2 months ago

doctorcooper commented 2 months ago

Summary

This simple adding fixes converting dictionary which contains decimal value and passing through API.

We've faced with issue that decimal values were ignored on Amplitude console on this framework, but legacy framework works well.

Checklist

[x] Does your PR title have the correct title format?
Does your PR have a breaking change?: No

crleona commented 2 months ago

Hi @doctorcooper, could you please fix the lint warnings? Otherwise, I have been working on a more comprehensive fix for Encodable support that will be ready soon.

doctorcooper commented 2 months ago

Hello @crleona !

Fixed lint warnings. Thanks!

crleona commented 2 months ago

Thanks @doctorcooper!

crleona commented 2 months ago

@doctorcooper, FYI: https://github.com/amplitude/Amplitude-Swift/pull/192

github-actions[bot] commented 2 months ago

:tada: This PR is included in version 1.7.0 :tada:

The release is available on:

GitHub release
v1.7.0

Your semantic-release bot :package::rocket: