search

amplitude / Amplitude-TypeScript

TypeScript Amplitude Analytics SDK
https://amplitude.github.io/Amplitude-TypeScript/
MIT License
141 stars 40 forks source link

setUserProperties is not exported #110

Closed baptistejamin closed 2 years ago

baptistejamin commented 2 years ago

Hello!

We are currently migrating to this project.

I just noticed that setUserProperties is not exported here: https://github.com/amplitude/Amplitude-TypeScript/blob/main/packages/analytics-browser/src/index.ts#L17

Is there any reason to export setUserId but not setUserProperties ?

qingzhuozhen commented 2 years ago

Hi @baptistejamin Thanks for the feedback. To set user properties, you can actually use the identify method, set the user properties via Identify method. Some example in https://developers.amplitude.com/docs/typescript-browser-beta#user-properties. That's why we didn't add the setUserProperties call earlier. Would you prefer a call like setUserProperties more or if the current solution is also good for you?

Also while you are currently migrating to use this SDK, we would love to learn how everything is going for you and if any thing more we could do. Thank you.

cc @kevinpagtakhan @dnshi

baptistejamin commented 2 years ago

It's kinda weird to provide all the previous methods such as logEvent or setUserId but not this one :)